Skip to content

Correct schema write test #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2023
Merged

Correct schema write test #1416

merged 1 commit into from
May 27, 2023

Conversation

kiendang
Copy link
Contributor

Discover this small "typo" while working on #1413.

<Mock>.called_once() just returns a Mock, so assert <Mock>.called_once() always passes. We want <Mock>.assert_called_once().

@kiendang @ulgens
Correct schema write test
a04f011 
<Mock>.called_once() just returns a Mock, so assert <Mock>.called_once()
always passes. We want <Mock>.assert_called_once().
@ulgens ulgens force-pushed the fix-assert-called-once branch from a5391a8 to a04f011 Compare May 27, 2023 13:43
@firaskafri firaskafri merged commit 38709d8 into main May 27, 2023
@firaskafri firaskafri deleted the fix-assert-called-once branch May 27, 2023 13:53
superlevure pushed a commit to loft-orbital/graphene-django that referenced this pull request Jul 19, 2023
@kiendang @superlevure
Correct schema write test (graphql-python#1416)
7612eeb 
<Mock>.called_once() just returns a Mock, so assert <Mock>.called_once()
always passes. We want <Mock>.assert_called_once().
@renovate renovate bot mentioned this pull request Feb 10, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulgens ulgens ulgens approved these changes

@firaskafri firaskafri firaskafri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kiendang @ulgens @firaskafri